Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Set default value to GUID #260

Merged
merged 1 commit into from
Jun 10, 2022
Merged

fix: Set default value to GUID #260

merged 1 commit into from
Jun 10, 2022

Conversation

gaocegege
Copy link
Member

We do not set groupID for CUDA-based images. This PR is to fix it.

Signed-off-by: Ce Gao cegao@tensorchord.ai

@gaocegege
fix: Set default value to GUID
5b20478 
Signed-off-by: Ce Gao <cegao@tensorchord.ai>
terrytangyuan
terrytangyuan approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terrytangyuan terrytangyuan merged commit 723b32f into main Jun 10, 2022
@terrytangyuan terrytangyuan deleted the gid branch June 10, 2022 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
envd sprint board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaocegege @terrytangyuan